Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust *ByValue to *ByDisplayValue #51

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Adjust *ByValue to *ByDisplayValue #51

merged 1 commit into from
Jun 5, 2019

Conversation

ppi-buck
Copy link
Collaborator

@ppi-buck ppi-buck commented Jun 5, 2019

These changes in typings were not done when changing the API from *ByValue to *ByDisplayValue

Fixes #42

What: Change typings to resemble newer *ByDisplayValue API

Why: API introduced breaking changes that were not resembled in typings of this project

How: by changing the typings to match the correct function names

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged

These changes in typings were not done when changing the API from *ByValue to *ByDisplayValue 

Fixes #42
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit fd3b321 into testing-library:master Jun 5, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @ppi-buck for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @ppi-buck! 🎉

@kentcdodds
Copy link
Member

Let's try that again...

@kentcdodds
Copy link
Member

@all-contributors please add @ppi-buck for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @ppi-buck! 🎉

@kentcdodds
Copy link
Member

lol, I just realized we've already added you 😂

@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@kentcdodds
Copy link
Member

🎉 This PR is included in version 4.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getByDisplayValue is missing in TypeScript types
2 participants