feat: Support ESLint 7.x

[MichaelDeBoey]

ESLint v7.0.0 is released 🎉

(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:

• eslint-plugin-import (New release supporting ESLint 7 import-js/eslint-plugin-import#1772)
  • Add eslint 7 to CI import-js/eslint-plugin-import#1715
  • import-js/eslint-plugin-import@6a110dd
  • Release
• eslint-plugin-jest (Support ESLint 7.x jest-community/eslint-plugin-jest#568)
  • ci: run tests against eslint@7 jest-community/eslint-plugin-jest#572
  • Release
• eslint-plugin-jest-dom (Support ESLint 7.x testing-library/eslint-plugin-jest-dom#45)
  • feat: Support ESLint 7.x testing-library/eslint-plugin-jest-dom#46
  • Release
• eslint-plugin-jsx-a11y (https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/683)
  • https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/684
  • Release
• eslint-plugin-react
  • [New] support eslint v7 jsx-eslint/eslint-plugin-react#2635
  • Release
• eslint-plugin-react-hooks (eslint-plugin-react-hooks peerDependency warning with eslint@7.0.0 facebook/react#18876)
  • feat(eslint-plugin-react-hooks): Support ESLint 7.x facebook/react#18878
  • deps: bump ESLint version to v7 facebook/react#18897
  • Release
• eslint-plugin-testing-library (Support ESLint 7.x testing-library/eslint-plugin-testing-library#138)
  • feat: Support ESLint 7.x testing-library/eslint-plugin-testing-library#139
  • Release
• eslint-find-rules (eslint v7 support sarbbottam/eslint-find-rules#318)
  • feat: Support ESLint 7.x sarbbottam/eslint-find-rules#319
  • Release

---

BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x

[kentcdodds]

Super. Thanks!

[MichaelDeBoey]

@kentcdodds It seems like kcd-scripts is taking the wrong eslint version (the one installed by kcd-scripts instead of by eslint-config-kentcdodds) to execute the lint script.

[kentcdodds]

There's a circular dependency. We'll need to update both. I don't mind if it's messed up for one release, so the order shouldn't matter.

[MichaelDeBoey]

@kentcdodds Let's first update this one then 🙂

I still have another problem.
Due to the fact that all Node.js/CommonJS rules have been deprecated, I included eslint-plugin-node to replace them.
But this means I have to include all the following rules too:

node/exports-style                             node/file-extension-in-import                  node/no-callback-literal                       node/no-deprecated-api                         node/no-exports-assign
node/no-extraneous-import                      node/no-extraneous-require                     node/no-missing-import                         node/no-missing-require                        node/no-restricted-import
node/no-restricted-require                     node/no-unpublished-bin                        node/no-unpublished-import                     node/no-unpublished-require                    node/no-unsupported-features/es-builtins
node/no-unsupported-features/es-syntax         node/no-unsupported-features/node-builtins     node/prefer-global/buffer                      node/prefer-global/console                     node/prefer-global/process
node/prefer-global/text-decoder                node/prefer-global/text-encoder                node/prefer-global/url                         node/prefer-global/url-search-params           node/prefer-promises/dns
node/prefer-promises/fs                        node/process-exit-as-throw                     node/shebang

Should I include all node rules or just remove all Node.js/CommonJS rules? 🤔

[kentcdodds]

Let's go ahead and configure those rules 👍

[kentcdodds]

Looks awesome! Thanks so much for all your work here!

[MichaelDeBoey]

Always a pleasure to help out 🙂

[MichaelDeBoey]

@kentcdodds Since CI is failing tests, this one won't be released either 😕
https://travis-ci.com/github/kentcdodds/eslint-config-kentcdodds/builds/185492446

[kentcdodds]

🎉 This PR is included in version 16.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀