Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cross-env #100

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Update cross-env #100

merged 2 commits into from
Oct 30, 2019

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Oct 29, 2019 •
edited
Loading

Updated cross-env so you could see the failing test (like you asked in #99 (comment))

@kentcdodds
Copy link
Owner

Ah, here, the only thing you need to do to get tests passing is to change cross-env/dist to cross-env/src :)

@MichaelDeBoey
Copy link
Contributor Author

@kentcdodds All tests pass now 🙂

kentcdodds
kentcdodds approved these changes Oct 30, 2019
View reviewed changes
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 4d12c54 into kentcdodds:master Oct 30, 2019
@kentcdodds
Copy link
Owner

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey deleted the update-dependencies branch October 30, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @kentcdodds