-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create definition files into provided folder #182
Conversation
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 85.14% 85.14%
=======================================
Files 17 17
Lines 424 424
Branches 162 162
=======================================
Hits 361 361
Misses 56 56
Partials 7 7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this change solves your problem 🤔
You're right I have forgotten a file 😄 |
should be good now, sorry for that 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super 👍
@all-contributors please add @marcosvega91 for code |
I've put up a pull request to add @marcosvega91! 🎉 |
🎉 This PR is included in version 7.5.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: Create definition files into the provided --out-dir
Why: Because definitions were always saved into
dist
folder. In @testing-lirabry/react-hooks we are usinglib
as out dirHow:
Checklist: