-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[chore] update readme, fix examples, show effects button (#2492)
* nit Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * readme Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * fix examples Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * show effects control Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * nit Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * nit Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * nit Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> --------- Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
- Loading branch information
1 parent
de8cb97
commit 21a445f
Showing
16 changed files
with
172 additions
and
119 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
21a445f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @igorDykhta , wasn't sure how else to reach out, but is there any chance you'd be able to confirm if the PyPy python package for keplergl is updated to work with all your improvements?
21a445f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think so. I didn't touch the Python part at all.
21a445f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the response!
Looking at the python package code, it seems like it's just a wrapper/widget for the JS code, except from what I can tell it was just a static copy of the compiled main.js / index.js files inside from September 2021. I'm a meager analyst unfamiliar with JS and loosely familiar with Python, any chance you would know how to update the python package with the latest JS update? or if you can explain how one would go about that, I'd be happy to.
21a445f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I can see @heshan0131 is the original author of keplergl-jupyter