[Chore] fix tests (#2602)

- Fix jest test by importing loader.gl/polyfill from esm
- Fix browser jsdom test by importing loaders.gl/polyfill from esm
- Import @kepler.gl src in test
- Delete unused files
- Update jsdom

Signed-off-by: Shan He <heshan0131@gmail.com>

.eslintrc

@@ -21,7 +21,7 @@
     "jestPuppeteer": true
   },
   "parser": "@typescript-eslint/parser",
-  "plugins": ["babel", "prettier", "react", "@typescript-eslint", "enzyme-deprecation"],
+  "plugins": ["babel", "prettier", "react", "@typescript-eslint", "enzyme-deprecation", "jest"],
   "rules": {
     "valid-jsdoc": 0,
     "no-var": 0,
@@ -53,9 +53,9 @@
       "files": ["*.ts", "*.tsx"],
       "rules": {
         "no-undef": 0,
-        "no-unused-vars": 0,
-      },
-    },
+        "no-unused-vars": 0
+      }
+    }
   ],
   "settings": {
     "react": {

.prettierrc.js

@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: MIT
+// Copyright contributors to the kepler.gl project
+
+module.exports = {
+  bracketSpacing: false,
+  printWidth: 100,
+  semi: true,
+  singleQuote: true,
+  trailingComma: "none"
+}

babel.config.js

@@ -3,6 +3,7 @@
 
 const {resolve} = require('path');
 const KeplerPackage = require('./package');
+const {RESOLVE_ALIASES} = require('./webpack/shared-webpack-configuration');
 
 const nodeModules = resolve(__dirname, 'node_modules');
 
@@ -30,8 +31,12 @@ const PLUGINS = [
         test: './test',
         // We explicitly transpile this ESM library in scripts/fix-dependencies.js and consume the transpiled version here
         // This may not be needed once switch to Jest is complete as it is handled by transformIgnorePatterns
-        '@mapbox/tiny-sdf': `${nodeModules}/@mapbox/tiny-sdf/index.cjs`
-      },
+        '@mapbox/tiny-sdf': `${nodeModules}/@mapbox/tiny-sdf/index.cjs`,
+        // compile from @kepler.gl src
+        ...RESOLVE_ALIASES,
+        // loaders.gl cjs bundle of polyfills is not transpiled properly, use esm instead
+        '@loaders.gl/polyfills': `${nodeModules}/@loaders.gl/polyfills/src`
+      }
     }
   ],
   [

bindings/kepler.gl-jupyter/keplergl/keplergl.py

@@ -1,7 +1,7 @@
-"""module for keplergl-jupyter"""
 # SPDX-License-Identifier: MIT
 # Copyright contributors to the kepler.gl project
 
+#module for keplergl-jupyter
 import base64
 import sys
 import json

examples/webpack.config.local.js

@@ -115,7 +115,13 @@ function makeLocalDevConfig(env, EXAMPLE_DIR = LIB_DIR, externals = {}) {
           test: /\.(js|ts|tsx)$/,
           use: ['source-map-loader'],
           enforce: 'pre',
-          exclude: [/node_modules\/react-palm/, /node_modules\/react-data-grid/, /node_modules\/@loaders.gl/, /node_module\/@probe.gl/]
+          exclude: [
+            /node_modules\/react-palm/,
+            /node_modules\/react-data-grid/,
+            /node_modules\/@loaders.gl/,
+            /node_modules\/@probe.gl/,
+            /node_modules\/@turf\/jsts/
+          ]
         },
         // for compiling apache-arrow ESM module
         {
@@ -129,18 +135,18 @@ function makeLocalDevConfig(env, EXAMPLE_DIR = LIB_DIR, externals = {}) {
             loader: 'babel-loader',
             options: {
               plugins: [
-                "@babel/plugin-transform-class-properties",
-                "@babel/plugin-transform-optional-chaining",
-                "@babel/plugin-transform-logical-assignment-operators",
-                "@babel/plugin-transform-nullish-coalescing-operator",
-                "@babel/plugin-transform-export-namespace-from"
+                '@babel/plugin-transform-class-properties',
+                '@babel/plugin-transform-optional-chaining',
+                '@babel/plugin-transform-logical-assignment-operators',
+                '@babel/plugin-transform-nullish-coalescing-operator',
+                '@babel/plugin-transform-export-namespace-from'
               ],
               include: [
                 /node_modules\/@loaders\.gl/,
                 /node_modules\/@probe\.gl/,
                 /node_modules\/@math\.gl/
               ],
-              exclude: [/node_modules\/(?!(@loaders\.gl|@probe\.gl|@math\.gl)).*/],
+              exclude: [/node_modules\/(?!(@loaders\.gl|@probe\.gl|@math\.gl)).*/]
             }
           }
         }
@@ -184,8 +190,8 @@ function makeBabelRule(env, exampleDir) {
       presets: ['@babel/preset-env', '@babel/preset-react', '@babel/preset-typescript'],
       plugins: [
         ['@babel/plugin-transform-typescript', {isTSX: true, allowDeclareFields: true}],
-        "@babel/plugin-transform-logical-assignment-operators",
-        "@babel/plugin-transform-nullish-coalescing-operator",
+        '@babel/plugin-transform-logical-assignment-operators',
+        '@babel/plugin-transform-nullish-coalescing-operator',
         '@babel/plugin-transform-class-properties',
         '@babel/plugin-transform-optional-chaining',
         '@babel/plugin-transform-export-namespace-from',

jest.config.js

@@ -10,14 +10,21 @@ const config = {
   verbose: true,
   testPathIgnorePatterns: [
     // ignore all dist computed directories
-    "<rootDir>/.*(/|\\\\)dist(/|\\\\).*"
+    '<rootDir>/.*(/|\\\\)dist(/|\\\\).*'
+  ],
+  testMatch: [
+    '<rootDir>/src/**/*.spec.(ts|tsx)',
+    '<rootDir>/src/**/*.spec.js',
+    '<rootDir>/test/**/*.spec.js'
   ],
-  testMatch: ['<rootDir>/src/**/*.spec.(ts|tsx)', '<rootDir>/src/**/*.spec.js', '<rootDir>/test/**/*.spec.js'],
   // Per https://jestjs.io/docs/configuration#transformignorepatterns-arraystring, transformIgnorePatterns ignores
   // node_modules and pnp folders by default so that they are not transpiled
   // Some libraries (even if transitive) are transitioning to ESM and need additional transpilation. Relevant issues:
   // - tiny-sdf: https://github.com/visgl/deck.gl/issues/7735
-  transformIgnorePatterns: ['/node_modules/(?!(.*@mapbox/tiny-sdf.*))', '\\.pnp\\.[^\\/]+$']
+  transformIgnorePatterns: [
+    '/node_modules\\/(?!(.*@mapbox\\/tiny-sdf\\.*|@loaders\\.gl))',
+    '\\.pnp\\.[^\\/]+$'
+  ]
 };
 
 module.exports = config;

jest.setup.js

@@ -2,8 +2,8 @@
 // Copyright contributors to the kepler.gl project
 
 import '@testing-library/jest-dom';
-import * as Utils from '@kepler.gl/utils';
-require('@loaders.gl/polyfills');
+import {installFilePolyfills} from '@loaders.gl/polyfills';
+installFilePolyfills();
 
 jest.mock('mapbox-gl/dist/mapbox-gl', () => ({
   Map: () => ({})
@@ -16,4 +16,3 @@ jest.mock('@kepler.gl/utils', () => ({
 }));
 
 global.URL.createObjectURL = jest.fn();
-

package.json

@@ -184,7 +184,7 @@
     "global": "^4.4.0",
     "jest": "^29.5.0",
     "jest-environment-jsdom": "^29.5.0",
-    "jsdom": "^16.4.0",
+    "jsdom": "^24.1.1",
     "json-loader": "^0.5.4",
     "maplibre-gl": "^3.6.2",
     "minimist": "^1.2.6",

src/components/src/modals/save-map-modal.spec.tsx

@@ -17,7 +17,7 @@ import {fireEvent} from '@testing-library/react';
 import SaveMapModalFactory from './save-map-modal';
 import {renderWithTheme} from 'test/helpers/component-jest-utils';
 import {useCloudListProvider} from '../hooks/use-cloud-list-provider';
-import {dataTestIds} from '@kepler.gl/constants/src';
+import {dataTestIds} from '@kepler.gl/constants';
 
 const SaveMapModal = SaveMapModalFactory();
 

test/browser/components/injector-test.js

@@ -109,13 +109,17 @@ test('Components -> injector -> wrong factory type', t => {
     </Provider>
   );
 
-  t.ok(spy.calledTwice, 'should call console.error twice');
   t.equal(
     spy.getCall(0).args[0],
     'Error injecting factory: ',
     'should warn when default factory is not provided'
   );
 
+  t.equal(
+    spy.getCall(1).args[0],
+    'factory and its replacement should be a function',
+    'should warn when default factory is not provided'
+  );
   // test if custom header is rendered
   t.ok(wrapper.find('.side-panel__panel-header').length, 'should render default header');