Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message in method of ItemSelector #210

Closed
ChunhongZhao opened this issue Aug 23, 2018 · 0 comments
Closed

Warning message in method of ItemSelector #210

ChunhongZhao opened this issue Aug 23, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@ChunhongZhao
Copy link

ChunhongZhao commented Aug 23, 2018

Describe the bug
Warning: Received false for a non-boolean attribute placeholder.

React version: v16

Suggest Solution

In src/components/common/item-selector/item-selector.js line 281
change <DropdownSelectValue placeholder={!hasValue}> to <DropdownSelectValue placeholder={hasValue}>

Reference
https://stackoverflow.com/questions/49784294/warning-received-false-for-a-non-boolean-attribute-how-do-i-pass-a-boolean-f?rq=1

@ziyili66 ziyili66 added the bug Something isn't working label Aug 24, 2018
heshan0131 pushed a commit that referenced this issue Aug 29, 2021
- Add MapsLayoutFactory for custom split map layouts
- Avoid manual calculation of the sizes of the map-containers and positioning them with CSS instead
- Add observeDimensions and useDimensions to allow components to listen to their size changes
- Fixed the issue with the HistogramPlot not being updated by adding a resize observer to RangeSlider

[Bug] Crash on Double-click in dual map (UN-1336) (#205)

* Fix: Pinning a tooltip moves it to the top left of the screen

* Changed width > 0 || height > 0 to width > 0 && height > 0

* Fix: Crash on Double-click in dual map

* Fix formatting

Fix: Map layers can't be moved on top (#210)
heshan0131 pushed a commit that referenced this issue Aug 29, 2021
- Add MapsLayoutFactory for custom split map layouts
- Avoid manual calculation of the sizes of the map-containers and positioning them with CSS instead
- Add observeDimensions and useDimensions to allow components to listen to their size changes
- Fixed the issue with the HistogramPlot not being updated by adding a resize observer to RangeSlider
- Crash on Double-click in dual map
- Fix: Pinning a tooltip moves it to the top left of the screen
- Changed width > 0 || height > 0 to width > 0 && height > 0
- Fix: Crash on Double-click in dual map
- Fix formatting
- Fix: Map layers can't be moved on top (#210)

Signed-off-by: Ilya Boyandin <iboyandin@foursquare.com>
heshan0131 added a commit that referenced this issue Aug 30, 2021
- Add MapsLayoutFactory for custom split map layouts
- Avoid manual calculation of the sizes of the map-containers and positioning them with CSS instead
- Add observeDimensions and useDimensions to allow components to listen to their size changes
- Fixed the issue with the HistogramPlot not being updated by adding a resize observer to RangeSlider
- Crash on Double-click in dual map
- Fix: Pinning a tooltip moves it to the top left of the screen
- Changed width > 0 || height > 0 to width > 0 && height > 0
- Fix: Crash on Double-click in dual map
- Fix formatting
- Fix: Map layers can't be moved on top (#210)
- Prevent padding around bottom widget, sidebar and map control from blocking input
- ResizeObserver debouncing

Signed-off-by: Ilya Boyandin <iboyandin@foursquare.com>
Co-authored-by: Ilya Boyandin <ilyabo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants