better handling provider tile update #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shan He <heshan0131@gmail.com>
| export const ProviderSelect = ({ | ||
| cloudProviders = [], | ||
| onSelect, | ||
| onSetCloudProvider, |
There was a problem hiding this comment.
is this still used?
There was a problem hiding this comment.
it is passed to CloudTile
|
|
||
| _selectProvider = providerName => { | ||
| this.props.onSetCloudProvider(providerName); | ||
| const provider = (this.props.cloudProviders || []).find(p => p.name === providerName); |
There was a problem hiding this comment.
what if provider is null?
I know we have a check in getSavedMaps but should we even dispatch the action if provider is undefined
There was a problem hiding this comment.
_selectProvider is callback passed to ProviderSelect which is rendered by cloudProviders.map(provider => ...). I don't think it is possible forprovider to be undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#990
Signed-off-by: Shan He heshan0131@gmail.com