Added functionality for the icons of the map control to make it overrideable on the theme #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasmartinrojo
force-pushed
the
feature/layerIcons
branch
from
d484c27 to
37301bd
Compare
heshan0131
reviewed
Sep 14, 2020
| @@ -45,7 +45,7 @@ export { | |||
| SaveExportDropdownFactory, | |||
| PanelHeaderDropdownFactory | |||
| } from './side-panel/panel-header'; | |||
| export {default as PanelHeaderAction} from './side-panel/panel-header-action'; | |||
| export {default as PanelHeaderActionFactory} from './side-panel/panel-header-action'; | |||
There was a problem hiding this comment.
Still need to export PanelHeaderAction
heshan0131
reviewed
Sep 14, 2020
src/components/map/map-control.js
Outdated
| MapLegendPanelFactory.deps = []; | ||
| export function MapLegendPanelFactory() { | ||
| const defaultActionIcons = { | ||
| legend() { |
There was a problem hiding this comment.
make it a key value object
const defaultActionIcons = {
legend: Legend
}
heshan0131
reviewed
Sep 14, 2020
src/components/map/map-control.js
Outdated
| onToggleMenuPanel(); | ||
| }} | ||
| > | ||
| {actionIcons.legend()} |
There was a problem hiding this comment.
{<actionIcons.legend height="22px"/>}
There was a problem hiding this comment.
fixed, good catch
heshan0131
reviewed
Sep 14, 2020
| } | ||
| SplitMapButtonFactory.deps = []; | ||
| export function SplitMapButtonFactory() { | ||
| const defaultActionIcons = { |
heshan0131
reviewed
Sep 14, 2020
| } | ||
| Toggle3dButtonFactory.deps = []; | ||
| export function Toggle3dButtonFactory() { | ||
| const defaultActionIcons = { |
heshan0131
reviewed
Sep 14, 2020
src/components/map/map-control.js
Outdated
| const defaultActionIcons = { | ||
| visible: EyeSeen, | ||
| hidden: EyeUnseen, | ||
| polygon() { |
There was a problem hiding this comment.
each item should have the same construct, why is value of visible a component, and polygon a function?
if you are providing a prop API does it make sense for people to provide icons in different type?
polygon: DrawPolygon
There was a problem hiding this comment.
you're correct. fixed
Signed-off-by: Nicolas Rojo <nicolas.martin.rojo@gmail.com> Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Nicolas Rojo <nicolas.martin.rojo@gmail.com> Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
heshan0131
force-pushed
the
feature/layerIcons
branch
from
50c1e6c to
26124c2
Compare
Signed-off-by: Shan He <heshan0131@gmail.com>
heshan0131
approved these changes
Sep 15, 2020
geostarters
added a commit
to geostarters/kepler.gl
that referenced
this pull request
Sep 17, 2020
[Enhancement] Added factory for the icons of the map control (keplergl#1273)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.