[Chore]: Technical: Isolate actions #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariaterekhova-actionengine
force-pushed
the
dt/actions_isolations
branch
3 times, most recently
from
c934b57 to
07dd659
Compare
heshan0131
reviewed
Aug 23, 2022
| export * from './vis-state-actions'; | ||
| export * from './ui-state-actions'; | ||
| export * from './map-state-actions'; | ||
| export * from './map-style-actions'; | ||
| export * from './identity-actions'; | ||
| export * from './provider-actions'; | ||
|
|
||
| /* eslint-disable prettier/prettier */ |
There was a problem hiding this comment.
why do we disable prettier here?
There was a problem hiding this comment.
That's because it throws an exception for every export type {... line. If you have an idea how it can be reconfigured - let me know, I'll change the eslint config
heshan0131
reviewed
Aug 24, 2022
src/components/modal-container.tsx
Outdated
| @@ -61,17 +61,20 @@ import { | |||
|
|
|||
| import {getFileFormatNames, getFileExtensions} from 'reducers/vis-state-selectors'; | |||
| import {MapStyle} from 'reducers'; | |||
| import {MapState, UiState, OnSuccessCallBack, OnErrorCallBack} from '@kepler.gl/types'; | |||
| import {MapState, UiState} from '@kepler.gl/types'; | |||
There was a problem hiding this comment.
merge import with line 77
heshan0131
reviewed
Aug 24, 2022
| import { | ||
| DEFAULT_NOTIFICATION_TYPES, | ||
| DEFAULT_NOTIFICATION_TOPICS, | ||
| DATASET_FORMATS, | ||
| OVERWRITE_MAP_ID | ||
| } from '@kepler.gl/constants'; | ||
| import {ProviderActions} from '@kepler.gl/actions'; |
There was a problem hiding this comment.
merge with import above
heshan0131
reviewed
Aug 24, 2022
| import {ActionTypes} from 'actions'; | ||
|
|
||
| import {exportFileToCloud, resetProviderStatus, setCloudProvider} from 'actions/provider-actions'; | ||
| import {} from '@kepler.gl/actions'; |
heshan0131
approved these changes
Aug 24, 2022
dariaterekhova-actionengine
force-pushed
the
dt/actions_isolations
branch
from
f228f27 to
8d2e570
Compare
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/actions_isolations
branch
from
8d2e570 to
409ccba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.