[Chore]: Technical: Isolate table-utils #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariaterekhova-actionengine
force-pushed
the
dt/table-utils-isolation
branch
from
406e09b to
9cf265b
Compare
|
high level comment, can we name this modules |
heshan0131
reviewed
Aug 24, 2022
src/components/bottom-widget.tsx
Outdated
| @@ -24,7 +24,7 @@ import TimeWidgetFactory from './filters/time-widget'; | |||
| import AnimationControlFactory from './common/animation-control/animation-control'; | |||
| import AnimationControllerFactory from './common/animation-control/animation-controller'; | |||
| import {ANIMATION_WINDOW, DIMENSIONS, FILTER_TYPES} from '@kepler.gl/constants'; | |||
| import {getIntervalBins} from 'reducers/filter-utils'; | |||
| import {getIntervalBins} from '@kepler.gl/table-utils'; | |||
There was a problem hiding this comment.
can this be moved to utils or reducers/filter-utils?
heshan0131
reviewed
Aug 24, 2022
| @@ -24,7 +24,7 @@ import {createSelector} from 'reselect'; | |||
| import {format} from 'd3-format'; | |||
| import moment from 'moment'; | |||
| import {SCALE_TYPES, SCALE_FUNC, ALL_FIELD_TYPES} from '@kepler.gl/constants'; | |||
| import {getTimeWidgetHintFormatter} from 'reducers/filter-utils'; | |||
| import {getTimeWidgetHintFormatter} from '@kepler.gl/table-utils'; | |||
There was a problem hiding this comment.
can this be moved to utils or reducers/filter-utils?
heshan0131
reviewed
Aug 24, 2022
| @@ -23,7 +23,7 @@ import styled from 'styled-components'; | |||
| import LoadingSpinner from 'components/common/loading-spinner'; | |||
| import {ExportImage} from '@kepler.gl/constants'; | |||
|
|
|||
| /** @typedef {import('reducers/ui-state-updaters').ExportImage} ExportImage */ | |||
| /** @typedef {import('reducers').ExportImage} ExportImage */ | |||
There was a problem hiding this comment.
is this lien still needed?
heshan0131
reviewed
Aug 24, 2022
src/components/modal-container.tsx
Outdated
| @@ -27,7 +27,7 @@ import document from 'global/document'; | |||
| import {EXPORT_DATA_TYPE_OPTIONS, EXPORT_MAP_FORMATS} from '@kepler.gl/constants'; | |||
| import ModalDialogFactory from './modals/modal-dialog'; | |||
| import {exportHtml, isValidMapInfo, exportMap, exportJson} from '@kepler.gl/utils'; | |||
| import {exportData} from 'reducers/export-utils'; | |||
| import {exportData} from 'reducers'; | |||
There was a problem hiding this comment.
merge line 30, 62, 63, 65?
dariaterekhova-actionengine
force-pushed
the
dt/table-utils-isolation
branch
2 times, most recently
from
1c2e37a to
b8ba7ad
Compare
heshan0131
approved these changes
Aug 26, 2022
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
… to utils Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/table-utils-isolation
branch
from
b8ba7ad to
7dafe50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.