[fix] handle empty properties in GeoJson file #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #2377
When the sampled values of a property are all
nullin a GeoJson file, kepler will not be able to load the file and raise error'Cannot read properties of undefined (reading 'type')'.Description
In getFieldsFromData(), the
Analyzer.computeColMetawill dump empty fields so the related fieldMeta is undefined, which causes the issue above.To fix this, in this PR, we simply assign the field type to
STRINGfor the dumped field, since dropping the column in the RowData could be expensive.Update the test case by adding a column with null values.