Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Example node-app Arrow Errors #2508

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[Fix] Example node-app Arrow Errors #2508

merged 1 commit into from
Jan 16, 2024

Conversation

tpulmano
Copy link
Contributor

Trying to run the node-app example fails with import errors like this:

ERROR in ./node_modules/apache-arrow/ipc/metadata/message.mjs 46:14-33
Can't import the named export 'Builder' from non EcmaScript module (only default export is available)
 @ ./node_modules/apache-arrow/Arrow.mjs
 @ ./node_modules/apache-arrow/Arrow.dom.mjs
 @ ./node_modules/@kepler.gl/utils/dist/arrow-data-container.js
 @ ./node_modules/@kepler.gl/utils/dist/index.js
 @ ./node_modules/@kepler.gl/components/dist/side-panel/layer-panel/layer-list.js
 @ ./node_modules/@kepler.gl/components/dist/index.js
 @ ./src/app.js
 @ ./src/main.js

Copying this fix from the demo-app resolves them:

// fix for arrow-related errors
{
test: /\.mjs$/,
include: /node_modules/,
type: 'javascript/auto'
}

Signed-off-by: Tomas Pulmano <git@tpulmano.com>
Signed-off-by: Tomas Pulmano <tomas.pulmano@bird.co>
Copy link
Collaborator

@lixun910 lixun910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@ibgreen ibgreen merged commit b3be6c9 into keplergl:master Jan 16, 2024
7 checks passed
@tpulmano tpulmano deleted the fix-node-app-arrow branch January 16, 2024 22:01
chrisgervang pushed a commit that referenced this pull request Feb 7, 2024
Signed-off-by: Tomas Pulmano <tomas.pulmano@bird.co>
Signed-off-by: Chris Gervang <chris@gervang.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants