Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Tooltip not working in exported HTML map #2556

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

ilyabo
Copy link
Collaborator

@ilyabo ilyabo commented Apr 1, 2024

Solves #2528 and #2536 (duplicate)

The fix updates the deps in the export map html file.

After fix, tooltip works in the exported map:

Kapture.2024-04-01.at.18.23.21.mp4

@ilyabo ilyabo force-pushed the fix/tooltip-not-working-in-html-export branch from 6443560 to 67cbee2 Compare April 1, 2024 16:30
ilyabo added 2 commits April 11, 2024 19:57
Signed-off-by: Ilya Boyandin <ilya@boyandin.me>
Signed-off-by: Ilya Boyandin <ilya@boyandin.me>
@ilyabo ilyabo force-pushed the fix/tooltip-not-working-in-html-export branch from a8b25d0 to 421c090 Compare April 11, 2024 18:04
@IlyaSolomatin
Copy link

@heshan0131 hi! could you please review this PR ? :)

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit c5c96c9
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/67063dd23cf44100089e833e
😎 Deploy Preview https://deploy-preview-2556--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ilyabo ilyabo merged commit 09e19f8 into master Oct 9, 2024
9 of 11 checks passed
@ilyabo ilyabo deleted the fix/tooltip-not-working-in-html-export branch October 9, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants