Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Kepler-Jupyter 0.3.4 with kepler v3 #2565

Merged
merged 13 commits into from
Apr 23, 2024
Merged

Conversation

lixun910
Copy link
Collaborator

@lixun910 lixun910 commented Apr 20, 2024

Summary:

  • Update Kepler-Jupyter using kepler.gl 3.0.0, and upgrade keplergl python package to version 0.3.4-alpha0.
    • Get ready to publish keplergl 0.3.4 python package to PyPi and Conda
  • Add new parameter: use_arrow=True (default is False) to allow load and render data faster using GeoArrow:

e.g.

KeplerGl(data={'data_1': df}, config=config, use_arrow=True)

or

map_1.add_data(df, 'data_1', use_arrow=True)`

Task:

  • build js for jupyter with kepler.gl v3
  • create python package
  • update dependencies
  • update documentation
  • Performance: load DataFrame or GeoPands DataFrame as Arrow table in the format of base64string to kepler-jupyter
Screenshot 2024-04-20 at 10 03 55 PM

@lixun910 lixun910 marked this pull request as draft April 20, 2024 18:26
Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit 2e393e1
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/6626fd98141be5000844d2be
😎 Deploy Preview https://deploy-preview-2565--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lixun910 lixun910 marked this pull request as ready for review April 21, 2024 05:06
@lixun910 lixun910 requested review from ibgreen and heshan0131 April 22, 2024 08:09
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
@lixun910 lixun910 changed the title [Enhance] Kepler-Jupyter with kepler v3 [Feat] Kepler-Jupyter with kepler v3 Apr 22, 2024
@lixun910 lixun910 changed the title [Feat] Kepler-Jupyter with kepler v3 [Feat] Kepler-Jupyter 0.3.4 with kepler v3 Apr 22, 2024
Signed-off-by: Xun Li <lixun910@gmail.com>
@lixun910
Copy link
Collaborator Author

@ibgreen @heshan0131 Can you help to take a look at this PR? With this PR, we can create a pre-release keplergl python package v0.3.4alpha0, so users can test it out. The use_arrow feature needs to be tested using larger data.

Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lixun910 Amazing work.

IF it is not too much work, I think it could be good to separarate this into two PRs, one for 3.0 upgrade and one for arrow support.

The python package is often the hardest part of kepler.gl to maintain (as most contributors are JS experts) so having the version upgrade changes separated in a PT would make for a great reference,

@ibgreen ibgreen merged commit 44526eb into master Apr 23, 2024
12 checks passed
@ibgreen ibgreen deleted the xli-jupyter-w-kepler-3 branch April 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants