Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Improved map bounds calculation and handled latitude issues #2632

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

igorDykhta
Copy link
Collaborator

for some reason WebMercatorViewport can't handle latitude -90,90 and throws an error
so we default to lat/lng (0,0)

This is the error

viewport.js:81 Uncaught Error: Pixel project matrix not invertible
at WebMercatorViewport16.Viewport5 (viewport.js:81:13)
at new WebMercatorViewport16 (web-mercator-viewport.js:92:5)


at getViewportFromMapState (map-utils.js:46:66)

To test it you can use min_latitude.csv

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit 0825a8e
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66df53868b4c6b0008e4c8b6
😎 Deploy Preview https://deploy-preview-2632--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@igorDykhta igorDykhta merged commit 16a3ac2 into master Sep 13, 2024
11 of 12 checks passed
@igorDykhta igorDykhta deleted the igr/ups/improved-map-bounds branch September 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants