Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Adding application config #2658

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

heshan0131
Copy link
Contributor

  • Application config

  • Update kepler-gl.tsx

  • Trying to fix failing tests

  • Move applicationConfig to separate file to avoid test errors

  • Revert "Trying to fix failing tests"

This reverts commit 1ee283aaa9b24fe968928ceb673402c35a022a71.

  • Moving export to the end

  • Adding missing dependency

  • Comment and more explicit export

  • Try to fix import errors

  • Remove unnecessary change

  • Moved applicationConfig to utils in another attempt to avoid errors in CI

  • Reorg

* Application config

* Update kepler-gl.tsx

* Trying to fix failing tests

* Move applicationConfig to separate file to avoid test errors

* Revert "Trying to fix failing tests"

This reverts commit 1ee283aaa9b24fe968928ceb673402c35a022a71.

* Moving export to the end

* Adding missing dependency

* Comment and more explicit export

* Try to fix import errors

* Remove unnecessary change

* Moved applicationConfig to utils in another attempt to avoid errors in CI

* Reorg
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit f2645d2
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66e9ef08f53685000882f934
😎 Deploy Preview https://deploy-preview-2658--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Shan He <heshan0131@gmail.com>
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the yarn.lock changes related?

@ibgreen
Copy link
Collaborator

ibgreen commented Sep 24, 2024

Remove proposal for discussion form PR title?

@heshan0131 heshan0131 changed the title [Chore] Adding application config (proposal for discussion) [Chore] Adding application config Oct 2, 2024
@heshan0131 heshan0131 merged commit 25a5b60 into master Oct 2, 2024
12 checks passed
@heshan0131 heshan0131 deleted the shan/ups/application-config branch October 2, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants