Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Layer Column Mode #2662

Merged
merged 5 commits into from
Sep 23, 2024
Merged

[feat] Layer Column Mode #2662

merged 5 commits into from
Sep 23, 2024

Conversation

igorDykhta
Copy link
Collaborator

  • Layer Column Mode
  • add ColumnMode support for TripLayer
  • Choose between geoJson and CSV columns for trip layer
  • create new component for column mode config
  • calculate animation config when update layer column
  • Fill all columns from column mode when initializing it from prop
  • Auto detect lat, lng, altitude field pairs
  • Auto create trip layer if a dataset contain field pairs, timestamp, and id | uuid fie
  • Add column config component test

@igorDykhta
[feat] Layer Column Mode
6791262 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

❌ Deploy Preview for keplergl2 failed. Why did it fail? →

Name Link
🔨 Latest commit e6b2973
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66f169562e5fee00080a98bb

@igorDykhta
lint fixes
4c18eb1 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
lint fixes
c4b9999 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
disable sample loading by default
19733e1 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
ibgreen
ibgreen approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits.

src/types/layers.d.ts
columnMode?: string;
};

export type LayerColumn = {value: string | null; fieldIdx: number; optional?: boolean};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: TSDoc comments?

@igorDykhta
nit
e6b2973 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta merged commit add6192 into master Sep 23, 2024
4 of 12 checks passed
@igorDykhta igorDykhta deleted the igr/ups/layer-column-mode branch September 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyabo ilyabo ilyabo approved these changes

@heshan0131 heshan0131 heshan0131 approved these changes

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorDykhta @ilyabo @heshan0131 @ibgreen