[Feat] Dynamic map lib config #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heshan0131
commented
Oct 7, 2024
heshan0131
commented
- Support dynamic map lib
✅ Deploy Preview for keplergl2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
igorDykhta
approved these changes
Oct 7, 2024
ibgreen
approved these changes
Oct 9, 2024
| @@ -5,7 +5,7 @@ import React, {Component} from 'react'; | |||
| import {polyfill} from 'react-lifecycles-compat'; | |||
| import classnames from 'classnames'; | |||
| import styled from 'styled-components'; | |||
| import MapGLMap, {MapRef} from 'react-map-gl/maplibre'; | |||
| import {Map, MapboxMap, MapRef} from 'react-map-gl'; | |||
There was a problem hiding this comment.
FWIW, @Pessimistress is separating maplibre into a new repo (since the APIs have forked), so there will be two dependencies down the road and we may need to build a higher level map lib abstraction.
heshan0131
force-pushed
the
upstream-dynamic-maplib
branch
from
f4a952e to
767d322
Compare
* Dynamic map lib * Type fixes Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
heshan0131
force-pushed
the
upstream-dynamic-maplib
branch
from
4d83c06 to
3b828cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.