[feat] Edit color legend value #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igorDykhta
commented
Oct 10, 2024
•
igorDykhta
commented
- feat: Allow color legend category edit
- Able to reset previously customized value
- Updated factory type definitions
- Add disableEdit to mapControl.mapLegend
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
✅ Deploy Preview for keplergl2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I was testing it, doesn't seem to work yet |
What exactly doesn't work? |
ilyabo
approved these changes
Oct 14, 2024
I was't able to edit categorical value. In the world flights map. Not sure if this PR includes categorical support, or that's in a later PR |
I double checked the code and it looks like the fix is included in the following PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.