[fix] Layer animation bugfixes #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igorDykhta
commented
Oct 22, 2024
igorDykhta
commented
- enable timesteps for setLayerAnimationTimeUpdater
- do not reset animationConfig when animatable
- [Bug] call setLayerAnimationTime after currentTime changed in updateAnimationDomain
- [fix]: Fixed animation config domain set to null when toggling layer visibility
- Fix: Changes to splitMaps layer visibility were overwritten by when layer animation enabled
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
✅ Deploy Preview for keplergl2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
heshan0131
approved these changes
Oct 23, 2024
MilheiroSantos
pushed a commit
to MilheiroSantos/kepler.gl
that referenced
this pull request
Nov 1, 2024
* enable timesteps for setLayerAnimationTimeUpdater * do not reset animationConfig when animatable * [Bug] call setLayerAnimationTime after currentTime changed in updateAnimationDomain * [fix]: Fixed animation config domain set to null when toggling layer visibility * Fix: Changes to splitMaps layer visibility were overwritten by when layer animation enabled Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> Co-authored-by: Ilya Boyandin <iboyandin@foursquare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.