Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the path to relative path in utils #2775

Merged

Conversation

indranildeveloper
Copy link
Contributor

@indranildeveloper indranildeveloper commented Nov 20, 2024

When built and used in an external web app, the @kepler.gl/utils was giving error because the application config was imported from ../../utils/src/application-config. After building the src folder is missing and there is only the dist folder, so updated the imports to use the relative path to get rid of the error.

  • Before in the build code:

Screenshot 2024-11-20 231658

  • After in the build code:

Screenshot 2024-11-20 231841

Signed-off-by: Indranil Halder <indranilhalder.dev@gmail.com>
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit 394498f
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/673e22b3c98077000868b2e6
😎 Deploy Preview https://deploy-preview-2775--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@indranildeveloper
Copy link
Contributor Author

@igorDykhta @heshan0131 @ibgreen love to get a review.

@igorDykhta igorDykhta self-requested a review November 20, 2024 18:07
Copy link
Collaborator

@igorDykhta igorDykhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@igorDykhta igorDykhta merged commit 931e2c6 into keplergl:master Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants