Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Don't modify height when fixed height is enabled; Height UI unification. #2804

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

igorDykhta
Copy link
Collaborator

  • height range and zoom factors are ignored when fixed height is turned on
  • elevation scale > height multiplier
  • size range > height range
  • size scale > height scale

…ification

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta requested a review from ilyabo December 1, 2024 23:24
Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit e723f96
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/674cf03d626b3e0008d449cd
😎 Deploy Preview https://deploy-preview-2804--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@igorDykhta igorDykhta merged commit 786aa36 into master Dec 6, 2024
12 checks passed
@igorDykhta igorDykhta deleted the igr/ups/fixed-height-ui-unification branch December 6, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants