Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

API Token Regex Incorrect #159

Closed
ghost opened this issue Jan 27, 2022 · 1 comment · Fixed by #160
Closed

API Token Regex Incorrect #159

ghost opened this issue Jan 27, 2022 · 1 comment · Fixed by #160

Comments

@ghost
Copy link

ghost commented Jan 27, 2022

Keptn API Tokens can contain + so deploying via helm fails when API tokens contain forbidden chars.

job-executor-service/chart/values.schema.json

Line 44 in b3eecce

"pattern": "^[A-Za-z0-9-.]{2,63}$"

pchila pushed a commit that referenced this issue Jan 27, 2022
@agardnerIT
fix: Allow '+' in API Token helm value (#160) (#159)
ed463da 
Signed-off-by: Adam Gardner <adam.gardner@dynatrace.com>
@pchila pchila linked a pull request Jan 27, 2022 that will close this issue
fix(#159) Fix API Token Regex #160
Merged
@pchila
Copy link
Contributor

pchila commented Jan 27, 2022

Thanks @Dynatrace-Adam-Gardner for the spotting the issue and providing the fix :) PR merged

@pchila pchila closed this as completed Jan 27, 2022
pchila added a commit that referenced this issue Jan 27, 2022
@pchila
Revert "fix: Allow '+' in API Token helm value (#160) (#159)"
f245fa3 
This reverts commit ed463da.
pchila added a commit that referenced this issue Jan 27, 2022
@pchila
fix: Revert "fix: Allow '+' in API Token helm value (#160) (#159)"
82ea46c 
This reverts commit ed463da.

Still not clear how a '+' character got into the keptn api token.
Needs more investigation about the root cause rather than a quick fix.
Reverting the change till we know more.
Reverts #160

Signed-off-by: Paolo Chila <paolo.chila@dynatrace.com>
pchila added a commit that referenced this issue Jan 27, 2022
@pchila
fix: Revert "fix: Allow '+' in API Token helm value (#160) (#159)"
ca73469 
This reverts commit ed463da.

Still not clear how a '+' character got into the keptn api token.
Needs more investigation about the root cause rather than a quick fix.
Reverting the change till we know more.
Reverts #160

Signed-off-by: Paolo Chila <paolo.chila@dynatrace.com>
pchila added a commit that referenced this issue Jan 27, 2022
@pchila
revert: Revert "fix: Allow '+' in API Token helm value (#160) (#159)"
195eba8 
This reverts commit ed463da.

Still not clear how a '+' character got into the keptn api token.
Needs more investigation about the root cause rather than a quick fix.
Reverting the change till we know more.
Reverts #160

refs: ed463da
Signed-off-by: Paolo Chila <paolo.chila@dynatrace.com>
pchila added a commit that referenced this issue Jan 27, 2022
@pchila
fix: Revert "fix: Allow '+' in API Token helm value (#160) (#159)"
96a64ac 
This reverts commit ed463da.

Still not clear how a '+' character got into the keptn api token.
Needs more investigation about the root cause rather than a quick fix.
Reverting the change till we know more.
Reverts #160

Signed-off-by: Paolo Chila <paolo.chila@dynatrace.com>
pchila added a commit that referenced this issue Jan 28, 2022
@pchila
fix: Revert "fix: Allow '+' in API Token helm value (#160) (#159)" (#165
91602dc 
)

This reverts commit ed463da.

Still not clear how a '+' character got into the keptn api token.
Needs more investigation about the root cause rather than a quick fix.
Reverting the change till we know more.
Reverts #160

Signed-off-by: Paolo Chila <paolo.chila@dynatrace.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#159) Fix API Token Regex
1 participant
@pchila