Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

chore: Update dependencies #356

Merged
merged 6 commits into from
Sep 7, 2022
Merged

chore: Update dependencies #356

merged 6 commits into from
Sep 7, 2022

Conversation

Raffy23
Copy link
Member

@Raffy23 Raffy23 commented Sep 6, 2022 •
edited
Loading

This PR

  • updates all dependencies

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022 •
edited
Loading

Test Results

130 tests   118 ✔️  2s ⏱️
  13 suites    12 💤
    1 files        0 ❌

Results for commit 9986978.

♻️ This comment has been updated with latest results.

TannerGabriel
TannerGabriel reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also update the go version in the Github actions scripts (CI, Integration tests, etc.).

@Raffy23
Copy link
Member Author

Raffy23 commented Sep 6, 2022

I will double check later, but I think all GitHub action should get the Go version from the go mod file

@TannerGabriel
Copy link
Member

I will double check later, but I think all GitHub action should get the Go version from the go mod file

If that is the case, we can most likely remove this environment variable.

@christian-kreuzberger-dtx
Copy link
Contributor

Can we please separate the go 1.18 update into another PR with a better title? :) Would be great for the changelog.

@Raffy23 Raffy23 changed the title chore: Update dependencies chore: Update dependencies and Go 1.18 Sep 6, 2022
TannerGabriel
TannerGabriel previously approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raffy23 Raffy23 marked this pull request as draft September 6, 2022 15:00
@Raffy23 Raffy23 changed the title chore: Update dependencies and Go 1.18 chore: Update dependencies Sep 6, 2022
@Raffy23
Copy link
Member Author

Raffy23 commented Sep 6, 2022

I'm moving the Go 1.18 update into a new PR and leave this one for just dependencies

@Raffy23 Raffy23 force-pushed the chore/update-dependencies branch 2 times, most recently from 0b8351f to d9130b8 Compare September 6, 2022 15:05
@Raffy23
Copy link
Member Author

Raffy23 commented Sep 6, 2022

PR depends on #357

@Raffy23 Raffy23 marked this pull request as ready for review September 6, 2022 15:06
@TannerGabriel TannerGabriel mentioned this pull request Sep 7, 2022
Merged
@Raffy23
chore: Update dependencies
1d99eec 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
chore: Remove unneded GO version from unit tests action
af9dea9 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
chore: Update actions/setup-go to version 3.3.0
bfd840c 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
chore: Update actions/github-script to 6.2.0
58d832f 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
chore: dawidd6/action-download-artifact to 2.23.0
7633fcb 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
chore: c-py/action-dotenv-to-setenv to v4
9986978 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

The following Docker Images have been built:

  • keptncontrib/job-executor-service:0.2.6-dev-PR-356,keptncontrib/job-executor-service:0.2.6-dev-PR-356.202209070655
  • keptncontrib/job-executor-service-initcontainer:0.2.6-dev-PR-356,keptncontrib/job-executor-service-initcontainer:0.2.6-dev-PR-356.202209070655

TannerGabriel
TannerGabriel approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raffy23 Raffy23 merged commit 6b613b1 into main Sep 7, 2022
@Raffy23 Raffy23 deleted the chore/update-dependencies branch September 7, 2022 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TannerGabriel TannerGabriel TannerGabriel approved these changes

@christian-kreuzberger-dtx christian-kreuzberger-dtx Awaiting requested review from christian-kreuzberger-dtx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Raffy23 @TannerGabriel @christian-kreuzberger-dtx