Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Bridge: Unify error / success notifications #5087

Closed
4 of 6 tasks
Tracked by #5282
laneli opened this issue Aug 31, 2021 · 2 comments · Fixed by #6620
Closed
4 of 6 tasks
Tracked by #5282

Bridge: Unify error / success notifications #5087

laneli opened this issue Aug 31, 2021 · 2 comments · Fixed by #6620
Assignees
Labels
bridge.2.0 Bridge Version 2 ux UX

Comments

@laneli
Copy link
Contributor

laneli commented Aug 31, 2021

In the bridge we have currently 2 different ways of showing errors to users:

  • With a grey popup (toast) on the bottom of the page that vanishes after a few seconds
    • This popup is used by the HTTP interceptor to push errors to the frontend
  • With a red bar that shows error information on form submit

For success we use the same bar as for errors on form submit but in green.

Suggestion:

  • Get rid of the interceptor error messages, as they are not very visible and do not provide useful information
    • For page loading / polling errors we already have a error message in place. Maybe we can reuse this instead of the toast messages.
  • Use https://barista.dynatrace.com/components/alert instead of the ktb-notification-bar for form submit feedback
    • Extend the component to also have a success state
    • Make it closable
    • Make it configurable for it to vanish after n seconds
    • Needs discussion: Show it on top of the related element, e.g. a form or the whole page that is affected - this will move the content a bit lower, but this is a common usage pattern for such notification elements, so I have no objections against it
    • Do not overlay it over the content, as content gets unreadable and also may get unusable because it overlays some interaction elements

Acceptance criteria

  • Shows a success message for form interactions that are successful
  • Shows an error message for form interactions that fail
  • Shows an error message for every other interaction that fails
  • Shows an error for severe problems that occur without interaction
  • Message can be closed
  • Message can be configured to vanish after n seconds
@laneli laneli added bridge.2.0 Bridge Version 2 usability labels Aug 31, 2021
@thisthat thisthat added this to the 0.11.0 (Bridge) milestone Sep 17, 2021
@thisthat thisthat added the ready-for-refinement Issue is relevant for the next backlog refinment label Sep 17, 2021
@thisthat thisthat mentioned this issue Sep 17, 2021
12 tasks
@johannes-b johannes-b added ux UX and removed usability labels Sep 28, 2021
@thisthat
Copy link
Member

thisthat commented Oct 5, 2021

The team agreed to split into different ticket for:

  • creating the component
  • each screen will be replaced with the new notification component

@thisthat thisthat removed the ready-for-refinement Issue is relevant for the next backlog refinment label Oct 18, 2021
@ermin-muratovic
Copy link
Member

#5213
This screen should also implement the new error notifications, instead of this blocking layout that breaks the view.

Kirdock added a commit that referenced this issue Jan 19, 2022
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Kirdock added a commit that referenced this issue Jan 27, 2022
* feat(bridge): Login via OpenID (#6076)

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* use different env for client redirect uri

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* build redirect URL with base and prefix

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* make user identifier configurable

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* logout with POST instead of GET, increased state timeout to 60 minutes

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* Added login via OpenID to README

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* added tests

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* added tests for OAuth flow, removed app in global, fixed non-terminating tests

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* adapted readme and fallback of user identifier

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* added new OAUTH env variables to installer

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* feat(bridge): Unify notifications (#5087)

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* remove hover background-color of close button. add title to close button

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* sticky notifications. padding for first notification

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* refactoring

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* refactoring

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* set return type

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* added OAUTH_SCOPE env variable for additional scopes

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* add new scope env to installer

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed test

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed code style

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed assigning data to component, always show new notifications on the bottom

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* redirect to logout page after logout. revoke token on logout

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed test

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed unit tests, added unit tests

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed test

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* added UI tests for notification

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* added space between pin icon and text

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* start fade out after defined duration

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* set type for component info to avoid incorrect parameters

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* improved equality check for notifications

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* implemented requested changes

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* implemented requested changes

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed code style

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed types

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed types again

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fixed unit tests

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* increase wait time for notification fade out

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bridge.2.0 Bridge Version 2 ux UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants