This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 245
Bridge: Unify error / success notifications #5087
Comments
thisthat
added
the
ready-for-refinement
Issue is relevant for the next backlog refinment
label
Sep 17, 2021
The team agreed to split into different ticket for:
|
thisthat
removed
the
ready-for-refinement
Issue is relevant for the next backlog refinment
label
Oct 18, 2021
#5213 |
Kirdock
added a commit
that referenced
this issue
Jan 19, 2022
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Kirdock
added a commit
that referenced
this issue
Jan 27, 2022
* feat(bridge): Login via OpenID (#6076) Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * use different env for client redirect uri Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * build redirect URL with base and prefix Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * make user identifier configurable Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * logout with POST instead of GET, increased state timeout to 60 minutes Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * Added login via OpenID to README Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * added tests Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * added tests for OAuth flow, removed app in global, fixed non-terminating tests Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * adapted readme and fallback of user identifier Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * added new OAUTH env variables to installer Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * feat(bridge): Unify notifications (#5087) Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * remove hover background-color of close button. add title to close button Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * sticky notifications. padding for first notification Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * refactoring Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * refactoring Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * set return type Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * added OAUTH_SCOPE env variable for additional scopes Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * add new scope env to installer Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed test Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed code style Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed assigning data to component, always show new notifications on the bottom Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * redirect to logout page after logout. revoke token on logout Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed test Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed unit tests, added unit tests Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed test Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * added UI tests for notification Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * added space between pin icon and text Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * start fade out after defined duration Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * set type for component info to avoid incorrect parameters Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * improved equality check for notifications Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * implemented requested changes Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * implemented requested changes Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed code style Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed types Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed types again Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * fixed unit tests Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com> * increase wait time for notification fade out Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the bridge we have currently 2 different ways of showing errors to users:
For success we use the same bar as for errors on form submit but in green.
Suggestion:
ktb-notification-bar
for form submit feedbackAcceptance criteria
The text was updated successfully, but these errors were encountered: