feat: generalize helm chart (#2282)

Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

.github/actions/deploy-klt-on-cluster/action.yml

@@ -68,9 +68,21 @@ runs:
         echo "Installing Keptn using helm"
         helm version
 
+        helm repo add keptn "https://charts.lifecycle.keptn.sh"
+        helm repo update
+
+        for chart_dir in ./lifecycle-operator/chart \
+                ./metrics-operator/chart \
+                ./klt-cert-manager/chart \
+                ./chart; do
+            cd "$chart_dir"
+            echo "updating charts for" $chart_dir
+            helm dependency update
+            helm dependency build
+            cd -  # Return to the previous directory
+        done
+
         cd ./chart
-        helm dependency update
-        helm dependency build
 
         touch tmp-values.yaml
         if [ "${{ inputs.allowed-namespaces }}" == "allowed_ns_on" ]; then

.github/scripts/.helm-tests/certificates-only/result.yaml

@@ -8,11 +8,14 @@ metadata:
   labels:
     app.kubernetes.io/component: rbac
     app.kubernetes.io/part-of: keptn-lifecycle-toolkit
-    helm.sh/chart: cert-manager-0.1.0
-    app.kubernetes.io/name: cert-manager
     app.kubernetes.io/instance: keptn-test
-    app.kubernetes.io/version: "v1.1.0"
     app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: cert-manager
+    app.kubernetes.io/version: vmyversion
+    helm.sh/chart: cert-manager-0.1.0
+    mamma: test
+  annotations:
+    ciao: commonannotation
 ---
 # Source: keptn/charts/certManager/templates/certificate-operator-rbac.yaml
 apiVersion: rbac.authorization.k8s.io/v1
@@ -21,11 +24,12 @@ metadata:
   name: certificate-operator-role
   namespace: "helmtests"
   labels:
-    helm.sh/chart: cert-manager-0.1.0
-    app.kubernetes.io/name: cert-manager
     app.kubernetes.io/instance: keptn-test
-    app.kubernetes.io/version: "v1.1.0"
     app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: cert-manager
+    app.kubernetes.io/version: vmyversion
+    helm.sh/chart: cert-manager-0.1.0
+    mamma: test
 rules:
 - apiGroups:
   - admissionregistration.k8s.io
@@ -76,11 +80,12 @@ metadata:
     app.kubernetes.io/component: rbac
     app.kubernetes.io/created-by: certificate-operator
     app.kubernetes.io/part-of: keptn-lifecycle-toolkit
-    helm.sh/chart: cert-manager-0.1.0
-    app.kubernetes.io/name: cert-manager
     app.kubernetes.io/instance: keptn-test
-    app.kubernetes.io/version: "v1.1.0"
     app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: cert-manager
+    app.kubernetes.io/version: vmyversion
+    helm.sh/chart: cert-manager-0.1.0
+    mamma: test
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
@@ -97,11 +102,14 @@ metadata:
   name: certificate-operator-role
   namespace: "helmtests"
   labels:
-    helm.sh/chart: cert-manager-0.1.0
-    app.kubernetes.io/name: cert-manager
     app.kubernetes.io/instance: keptn-test
-    app.kubernetes.io/version: "v1.1.0"
     app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: cert-manager
+    app.kubernetes.io/version: vmyversion
+    helm.sh/chart: cert-manager-0.1.0
+    mamma: test
+  annotations:
+    ciao: commonannotation
 rules:
 - apiGroups:
   - ""
@@ -132,11 +140,14 @@ metadata:
     app.kubernetes.io/component: rbac
     app.kubernetes.io/created-by: certificate-operator
     app.kubernetes.io/part-of: keptn-lifecycle-toolkit
-    helm.sh/chart: cert-manager-0.1.0
-    app.kubernetes.io/name: cert-manager
     app.kubernetes.io/instance: keptn-test
-    app.kubernetes.io/version: "v1.1.0"
     app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: cert-manager
+    app.kubernetes.io/version: vmyversion
+    helm.sh/chart: cert-manager-0.1.0
+    mamma: test
+  annotations:
+    ciao: commonannotation
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
@@ -156,11 +167,14 @@ metadata:
     app.kubernetes.io/component: rbac
     app.kubernetes.io/created-by: certificate-operator
     app.kubernetes.io/part-of: keptn-lifecycle-toolkit
-    helm.sh/chart: cert-manager-0.1.0
-    app.kubernetes.io/name: cert-manager
     app.kubernetes.io/instance: keptn-test
-    app.kubernetes.io/version: "v1.1.0"
     app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: cert-manager
+    app.kubernetes.io/version: vmyversion
+    helm.sh/chart: cert-manager-0.1.0
+    mamma: test
+  annotations:
+    ciao: commonannotation
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
@@ -180,11 +194,14 @@ metadata:
     app.kubernetes.io/component: keptn-cert-manager
     app.kubernetes.io/part-of: keptn-lifecycle-toolkit
     control-plane: certificate-operator
-    helm.sh/chart: cert-manager-0.1.0
-    app.kubernetes.io/name: cert-manager
     app.kubernetes.io/instance: keptn-test
-    app.kubernetes.io/version: "v1.1.0"
     app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: cert-manager
+    app.kubernetes.io/version: vmyversion
+    helm.sh/chart: cert-manager-0.1.0
+    mamma: test
+  annotations:
+    ciao: commonannotation
 spec:
   replicas: 1
   selector:
@@ -217,7 +234,7 @@ spec:
               value: "true"
             - name: KUBERNETES_CLUSTER_DOMAIN
               value: cluster.local
-          image: ghcr.io/keptn/certificate-operator:v1.1.0
+          image: testreg/ghcr.io/keptn/certificate-operator:v1.1.0
           imagePullPolicy: Always
           name: certificate-operator
           resources:

.github/scripts/.helm-tests/certificates-only/values.yaml

@@ -4,3 +4,13 @@ lifecycleOperator:
   enabled: false
 metricsOperator:
   enabled: false
+
+global:
+  imageRegistry: "testreg"
+  imagePullSecrets: []
+  commonAnnotations:
+    ciao: commonannotation
+  commonLabels:
+    mamma : "test"
+    app.kubernetes.io/version: vmyversion
+