You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #1421 we introduce multiple specs in the TaskDefinition CRD, so that the user can either declare a task using JS or a custom container. Since the TaskDefinition CRD is becoming more complex, we should introduce a validating webhook to alert users immediately if the CR being applyed is wrongly configured.
the webhook verifies that Exactly one spec should be defined in a TaskDefinition, this could be a custom container spec is filled in OR a JS function spec (OR if already implemented a Python function spec) but NOT both or more. Also, at least one should always be filled in for the TaskDefinition to make sense, otherwise, the job would run nothing.
integration test to prove the webhook works (at least one test assertions that expects failure and one that passes) you can find an example of error assertions in kuttl here
DoD
applying a TaskDefinitions with multiple or no runtime spec fails with a clear K8s API message
Details
With #1421 we introduce multiple specs in the
TaskDefinition
CRD, so that the user can either declare a task using JS or a custom container. Since theTaskDefinition
CRD is becoming more complex, we should introduce a validating webhook to alert users immediately if the CR being applyed is wrongly configured.AC
DoD
TaskDefinitions
with multiple or no runtime spec fails with a clear K8s API messageResources
Depends on
The text was updated successfully, but these errors were encountered: