-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add validating webhook for KeptnTaskDefinition #1514
feat: add validating webhook for KeptnTaskDefinition #1514
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
d6a4800
to
2af1475
Compare
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
…ffrey1330/lifecycle-toolkit into feat/1486/validating_webhook Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this webhook to work when a KeptnTaskDefinition
gets created
or updated
, thus we'll need to return the validateKeptnTaskDefinition
function on ValidateCreate
and ValidateUpdate
.
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small typo, sorry. Can you fix this? @geoffrey1330
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go
Outdated
Show resolved
Hide resolved
…est.go Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
…) methods Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Kudos, SonarCloud Quality Gate passed!
|
@rakshitgondwal @geoffrey1330 awesome job! Thank you very much for contribution :) |
Kudos to @geoffrey1330! |
Thanks for the support @rakshitgondwal |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com> Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Fixes #1486 Added webhook validation for TaskDefinitions in the lifecycle operator