Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adapt validation webhook to consider new fields for python-runtime functionality #1527

Closed
3 tasks
odubajDT opened this issue Jun 7, 2023 · 2 comments · Fixed by #1534
Closed
3 tasks

chore: adapt validation webhook to consider new fields for python-runtime functionality #1527

odubajDT opened this issue Jun 7, 2023 · 2 comments · Fixed by #1534
Assignees
@geoffrey1330
Labels
chore Maintenance

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Jun 7, 2023

Goal

With introducing the python-rutime, the validating webhook introduced here does not check all the required fields. Therefore with changes made in this PR it is necessary to adapt the webhook.

DoD

  • fields .spec.python and .spec.deno in KeptnTaskDefinition are checked as part of the validation webhook introduced here
  • Unit tests
  • Integration tests
@odubajDT odubajDT added chore Maintenance operator labels Jun 7, 2023
@geoffrey1330
Copy link
Member

Hi @odubajDT could you please assign me to this issue.

@odubajDT
Copy link
Contributor Author

odubajDT commented Jun 7, 2023

Sure, thank you @geoffrey1330

@odubajDT odubajDT mentioned this issue Jun 7, 2023
Merged
@geoffrey1330 geoffrey1330 mentioned this issue Jun 7, 2023
Merged
@geoffrey1330 geoffrey1330 mentioned this issue Jun 22, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffrey1330 geoffrey1330

Labels
chore Maintenance
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
No milestone
2 participants
@geoffrey1330 @odubajDT