-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): adapt TaskDefinition validation webhook to consider python and deno runtime #1534
feat(operator): adapt TaskDefinition validation webhook to consider python and deno runtime #1534
Conversation
…ime and deno functionality Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 63.04% 63.22% +0.18%
==========================================
Files 142 142
Lines 10779 10794 +15
==========================================
+ Hits 6796 6825 +29
+ Misses 3724 3714 -10
+ Partials 259 255 -4
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Nice work! Can you please add some integration tests and also adapt the failing unit tests ? Thank you! |
Alright I will do that |
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error with unit tests should be resolved after fixing these @geoffrey1330
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Hello @geoffrey1330 nice work! The PR looks good, can you just please check why the integration tests are failing? Thank you |
test/integration/validate-taskdefinition/00-teststep-install.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
…ntime_functionality
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Kudos, SonarCloud Quality Gate passed!
|
Thank you for your contribution @geoffrey1330 :) |
…ython and deno runtime (keptn#1534) Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
…ython and deno runtime (keptn#1534) Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Fixes #1527 Added logic to the validation webhook to accommodate the new fields for python-runtime and deno functionality.
Signed-off-by: geoffrey1330 israelgeoffrey13@gmail.com