Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: scheduling gates beta verison #1249

Closed
wants to merge 14 commits into from
Closed

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Apr 19, 2023

I had to tweak imports of controller runtime since the new version supporting k8s 1.27.1 is not yet released.

for the sake of poc the inner dependencies with klt-cert-manager has been replaced with pr ones for the sake of testing.

A few unit tests need to be fixed due to breaking changes in the library and there is a curious nil pointer issue with the decoder: the interface for injecting it has been removed from controller runtime, so we need to initiate it when creating the handlers kubernetes-sigs/controller-runtime#2134
But overall a separate webhook for gates seems to work.
image

@github-actions github-actions bot added documentation Improvements or additions to documentation operator ops labels Apr 19, 2023
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 46cae39
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/643f9cff5de2a80008bcb486
😎 Deploy Preview https://deploy-preview-1249--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #1249 (bbd0a25) into main (4815986) will decrease coverage by 3.70%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   61.67%   57.98%   -3.70%     
==========================================
  Files         137      102      -35     
  Lines       10473     8701    -1772     
==========================================
- Hits         6459     5045    -1414     
+ Misses       3763     3475     -288     
+ Partials      251      181      -70     
Impacted Files Coverage Δ
operator/apis/lifecycle/v1alpha3/common/common.go 100.00% <ø> (ø)
operator/controllers/common/helperfunctions.go 100.00% <ø> (+1.35%) ⬆️
...lers/lifecycle/keptnworkloadinstance/controller.go 80.64% <0.00%> (-1.99%) ⬇️
...rator/webhooks/pod_mutator/pod_mutating_webhook.go 7.77% <ø> (-64.33%) ⬇️
klt-cert-manager/pkg/webhook/manager.go 100.00% <100.00%> (ø)

... and 55 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.59% <100.00%> (+0.04%) ⬆️
component-tests 60.00% <0.00%> (-0.18%) ⬇️
lifecycle-operator ?
metrics-operator ?
scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 19cdf89
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/646b3996a9bffc00081c676c
😎 Deploy Preview https://deploy-preview-1249--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>

fix operator import

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: fix lib import

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: fix lib import

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: fix lib import

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: rebased with controller runtime

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: up kind version

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: removed logger in favour of test logger

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: fixed otel

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: patched k8s version for sigs.k8s.io/controller-runtime

Signed-off-by: realanna <anna.reale@dynatrace.com>

poc: added gates

Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna and others added 11 commits May 19, 2023 10:30
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be
closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 22, 2023
@github-actions github-actions bot closed this Jul 30, 2023
@thisthat thisthat deleted the poc/scheduling_gates branch August 31, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant