-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for controller runtime v0.15.0 #1603
feat: added support for controller runtime v0.15.0 #1603
Conversation
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz remove this is out of scope of the pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as from other comments out of scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this changes plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this changes plz
"/gate-v1-pod": { | ||
Handler: &gating.PodGatingWebhook{ | ||
Client: mgr.GetClient(), | ||
Tracer: otel.Tracer("keptn/gatewebhook"), | ||
Decoder: decoder, | ||
Recorder: mgr.GetEventRecorderFor("keptn/gatewebhook"), | ||
Log: ctrl.Log.WithName("Gates Mutating Webhook"), | ||
}, | ||
}, | ||
}); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is not needed in this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove changes to this file plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this changes plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this changes plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is out of scope, plz reove the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove changes to this file plz
@@ -72,4 +72,4 @@ require ( | |||
sigs.k8s.io/yaml v1.3.0 // indirect | |||
) | |||
|
|||
replace golang.org/x/net => golang.org/x/net v0.10.0 | |||
replace sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is not needed, please remove :)
closed in favor of #1701 |
Signed-off-by: geoffrey1330 israelgeoffrey13@gmail.com
fixes #1457