Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for controller runtime v0.15.0 #1603

Conversation

geoffrey1330
Copy link
Member

@geoffrey1330 geoffrey1330 commented Jun 21, 2023

Signed-off-by: geoffrey1330 israelgeoffrey13@gmail.com
fixes #1457

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 9b4f928
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6493195bcf2983000845dc08
😎 Deploy Preview https://deploy-preview-1603--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@geoffrey1330 geoffrey1330 changed the title Added support for controller runtime v0.15.0 feat: added support for controller runtime v0.15.0 Jun 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remove this is out of scope of the pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope please remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as from other comments out of scope

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this changes plz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this changes plz

Comment on lines +363 to 372
"/gate-v1-pod": {
Handler: &gating.PodGatingWebhook{
Client: mgr.GetClient(),
Tracer: otel.Tracer("keptn/gatewebhook"),
Decoder: decoder,
Recorder: mgr.GetEventRecorderFor("keptn/gatewebhook"),
Log: ctrl.Log.WithName("Gates Mutating Webhook"),
},
},
}); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is not needed in this pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove changes to this file plz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this changes plz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this changes plz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file plz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is out of scope, plz reove the file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove changes to this file plz

@@ -72,4 +72,4 @@ require (
sigs.k8s.io/yaml v1.3.0 // indirect
)

replace golang.org/x/net => golang.org/x/net v0.10.0
replace sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.15.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is not needed, please remove :)

@RealAnna
Copy link
Contributor

RealAnna commented Jul 28, 2023

closed in favor of #1701

@RealAnna RealAnna closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support controller runtime v0.15.0
2 participants