feat: added klt-cert-manager support for controller runtime v0.15.0 #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
- Coverage 63.47% 56.66% -6.81%
==========================================
Files 142 95 -47
Lines 10898 8547 -2351
==========================================
- Hits 6917 4843 -2074
+ Misses 3719 3562 -157
+ Partials 262 142 -120
... and 70 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
7 tasks
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
…_klt-cert-manager Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
RealAnna
reviewed
Jul 3, 2023
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
…_klt-cert-manager
RealAnna
reviewed
Jul 3, 2023
RealAnna
reviewed
Jul 3, 2023
RealAnna
reviewed
Jul 3, 2023
RealAnna
reviewed
Jul 3, 2023
RealAnna
reviewed
Jul 3, 2023
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
|
SonarCloud Quality Gate failed.
|
thisthat
reviewed
Jul 10, 2023
| "github.com/keptn/lifecycle-toolkit/klt-cert-manager/pkg/certificates" | ||
| certCommon "github.com/keptn/lifecycle-toolkit/klt-cert-manager/pkg/common" | ||
| "github.com/keptn/lifecycle-toolkit/klt-cert-manager/pkg/webhook" | ||
| "github.com/geoffrey1330/lifecycle-toolkit/klt-cert-manager/pkg/certificates" |
There was a problem hiding this comment.
please, use keptn in the imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: geoffrey1330 israelgeoffrey13@gmail.com