Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added klt-cert-manager support for controller runtime v0.15.0 #1686

Conversation

geoffrey1330
Copy link
Member

@geoffrey1330 geoffrey1330 commented Jul 6, 2023

Signed-off-by: geoffrey1330 israelgeoffrey13@gmail.com
fixes: #1457

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 2477ff5
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64a6a6d325dba20008566479
😎 Deploy Preview https://deploy-preview-1686--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1686 (f2a34b1) into main (78ba574) will decrease coverage by 7.01%.
The diff coverage is n/a.

❗ Current head f2a34b1 differs from pull request most recent head 6e962ed. Consider uploading reports for the commit 6e962ed to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   63.47%   56.47%   -7.01%     
==========================================
  Files         142       95      -47     
  Lines       10899     8636    -2263     
==========================================
- Hits         6918     4877    -2041     
+ Misses       3719     3614     -105     
+ Partials      262      145     -117     

see 75 files with indirect coverage changes

Flag Coverage Δ
certificate-operator ?
component-tests 59.27% <ø> (ø)
lifecycle-operator ?
metrics-operator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna
Copy link
Contributor

RealAnna commented Jul 12, 2023

we cannot move forward with this due to a bug in the dependencies, closing for now in favor of #1701 where the problem is documented

@RealAnna RealAnna closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support controller runtime v0.15.0
2 participants