-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aggregation functions support for metrics controller #1802
feat: aggregation functions support for metrics controller #1802
Conversation
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
==========================================
- Coverage 84.18% 84.06% -0.13%
==========================================
Files 150 150
Lines 9525 9581 +56
==========================================
+ Hits 8019 8054 +35
- Misses 1221 1239 +18
- Partials 285 288 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just tried out this new functionality on my cluster. To also reach the getStepQueryResults
function in the unit tests, we will need to do some refactoring, but this will exceed the scope of this PR. I will create a follow up issue to tackle the refactoring
Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
157be77
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #1737
Changes made: