Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: how to migrate quality gates to Keptn Analysis feature #2251

Merged
merged 17 commits into from
Oct 11, 2023
Merged

docs: how to migrate quality gates to Keptn Analysis feature #2251

merged 17 commits into from
Oct 11, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Oct 9, 2023 •
edited
Loading

This PR:

  • Adds instructions for converting Keptn v1 quality gates to Keptn Analysis
  • Creates stub files for the yaml-crd-ref pages for the resources used for the Keptn Analysis feature. This lets me implement xrefs to these pages. The content of these pages is being developed in docs: ref pages for Analysis CRDs (BAD!) #2219
  • Rewrites to the beginning of the "Migrate Quality Gates" page to reflect that Analysis is available as well as Keptn Metrics and Evaluations

Closes #2175

@StackScribe
docs: how to migrate quality gates to Keptn Analysis feature
98c5e9d 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe added this to the 0.9 milestone Oct 9, 2023
@StackScribe StackScribe self-assigned this Oct 9, 2023
@StackScribe StackScribe requested review from a team as code owners October 9, 2023 09:56
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 9, 2023
@netlify
Copy link

netlify bot commented Oct 9, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit be207b3
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/652531dbb816a50008d7edf9
😎 Deploy Preview https://deploy-preview-2251--keptn-lifecycle-toolkit.netlify.app/docs/migrate/metrics-observe
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@StackScribe
markdownlint-fix
86af4cf 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
xrefs and code block syntax
6f06c37 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
another xref
583ff32 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
StackScribe and others added 9 commits October 9, 2023 08:07
@StackScribe @bacherfl
Update docs/content/en/docs/migrate/metrics-observe/_index.md
986ca70 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs/content/en/docs/migrate/metrics-observe/_index.md
f24b1d9 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs/content/en/docs/migrate/metrics-observe/_index.md
e24abb9 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs/content/en/docs/migrate/metrics-observe/_index.md
e7069df 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs/content/en/docs/migrate/metrics-observe/_index.md
e4c8afc 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs/content/en/docs/migrate/metrics-observe/_index.md
f0d049d 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
Flo's comments; update strategy
45dd7b7 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
markdownlint-fix
63fa93e 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe
small edit
6151511 
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs/content/en/docs/migrate/metrics-observe/_index.md
dc22be3 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @bacherfl
Update docs/content/en/docs/migrate/metrics-observe/_index.md
83301cc 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
bacherfl
bacherfl previously approved these changes Oct 10, 2023
View reviewed changes
@StackScribe
Update docs/content/en/docs/migrate/metrics-observe/_index.md
7d88516 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe @odubajDT
Update docs/content/en/docs/migrate/metrics-observe/_index.md
be207b3 
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odubajDT odubajDT merged commit c1166ff into keptn:main Oct 11, 2023
18 checks passed
@keptn-bot keptn-bot mentioned this pull request Oct 11, 2023
Merged
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
@StackScribe @bacherfl @odubajDT
docs: how to migrate quality gates to Keptn Analysis feature (keptn#2251
32f5101 
)

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

document how to migrate from quality gates to Keptn analysis
3 participants
@StackScribe @bacherfl @odubajDT