Add FFT Ops #480
Merged
Add FFT Ops #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abheesht17
commented
Jul 14, 2023
mattdangerw
approved these changes
Jul 14, 2023
|
Are you able to add it to the numpy backend as well? We can probably just redirect to jax like we do for most nn ops. |
Redirected to JAX for NumPy backend! |
fchollet
approved these changes
Jul 20, 2023
adi-kmt
pushed a commit
to adi-kmt/keras-core
that referenced
this pull request
Jul 21, 2023
* Add FFT Ops * Fixes * Fix torch * Address Matt's comments * Address Francois' comments * Shift docstrings to correct fns * Add NumPy backend FFT ops * Fix numpy backend * Minor change * Redirect NumPy FFT to JAX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #429
The reason for not supporting all args at the moment is that TensorFlow supports none of those args. Moreover, there are some inconsistencies between the NumPy FFT API and JAX FFT API. We need a very minimal version for FNet (and for most usecases, I suppose). This can be extended later to support all args.