Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated math.py & nn.py with docstrings. #484

Merged
merged 15 commits into from
Jul 16, 2023
Merged

Conversation

Sheiphan
Copy link
Contributor

@Sheiphan Sheiphan commented Jul 15, 2023

Updated keras_core/ops/math.py and keras_core/ops/nn.py with docstring.

Please do let me know if any changes are needed.

@google-cla
Copy link

google-cla bot commented Jul 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Sheiphan Sheiphan changed the title Updated math.py with docstrings. Updated math.py & nn.py with docstrings. Jul 15, 2023
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/nn.py Outdated Show resolved Hide resolved
@Sheiphan
Copy link
Contributor Author

I feel like I have made all the necessary changes.
Do let me know if anything needs to be changed.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/nn.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/nn.py Outdated Show resolved Hide resolved
keras_core/ops/nn.py Outdated Show resolved Hide resolved
keras_core/ops/nn.py Outdated Show resolved Hide resolved
@Sheiphan
Copy link
Contributor Author

Thanks you for your patience.
Check if everything is alright.

keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/math.py Show resolved Hide resolved
keras_core/ops/math.py Outdated Show resolved Hide resolved
keras_core/ops/nn.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fchollet fchollet merged commit 6fed5a3 into keras-team:main Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants