Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node test #557

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Node test #557

merged 1 commit into from
Jul 20, 2023

Conversation

adi-kmt
Copy link
Contributor

@adi-kmt adi-kmt commented Jul 20, 2023

Fixed the comments

  • Added kwargs to the test
  • Removed dict
  • Added comments on test cases

Moved the previous PR here.

fchollet
fchollet approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fchollet fchollet merged commit b470eb4 into keras-team:main Jul 20, 2023
adi-kmt added a commit to adi-kmt/keras-core that referenced this pull request Jul 21, 2023
@adi-kmt
node test (keras-team#557)
0ba17cf
@adi-kmt adi-kmt deleted the node_test branch July 22, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adi-kmt @fchollet