Improve TensorFlowTrainer compatibility for TF<2.9
#598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Jul 25, 2023
| @@ -22,6 +24,11 @@ def __init__(self): | |||
| self.test_function = None | |||
| self.predict_function = None | |||
|
|
|||
| if Version(tf.__version__) >= Version('2.9.0'): | |||
| self.support_reduce_retracing = True | |||
There was a problem hiding this comment.
Please make it a private attribute, self._supports_reduce_retracing
| reduce_retracing=True, | ||
| ) | ||
| kwargs = {'jit_compile': self.jit_compile} | ||
| if self.support_reduce_retracing is True: |
There was a problem hiding this comment.
Just if self._supports_reduce_retracing:
|
@fchollet Thank you for the review. The PR has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if support for TensorFlow older versions is intended, but it would be nice to take care of backward compatability because not everyone uses the latest TensorFlow. The current
TensorFlowTrainerusestf.functionwith the parameterreduce_retracing(e.g., here), but thereduce_retracinghas been introduced since TF 2.9. This PR is able to handle this issue with adaptive keyword arguments.