Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port digit addition rnn example to keras-core #614

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

anas-rz
Copy link
Contributor

@anas-rz anas-rz commented Jul 26, 2023

Porting addition example using RNN to keras-core.
The model works on all backends with CPU.
On GPU it shows an error with TensorFlow which is likely from tensorflow Colab to reproduce.
Tested it in Colab and local environment on Ubuntu.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the PR and the bug report. I fixed the bug.

@fchollet fchollet merged commit de4ca60 into keras-team:main Jul 26, 2023
@anas-rz anas-rz deleted the port-digit-addition-rnn branch July 26, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants