Add docstrings in numpy #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Jul 26, 2023
keras_core/ops/numpy.py
Outdated
|
|
||
| Example: | ||
| >>> x = keras_core.ops.convert_to_tensor([1, -1]) | ||
| array([0. , 3.1415927], dtype=float32) |
There was a problem hiding this comment.
You can remove the extra whitespace
keras_core/ops/numpy.py
Outdated
|
|
||
| The quadrant (i.e., branch) is chosen so that `arctan2(x1, x2)` is the | ||
| signed angle in radians between the ray ending at the origin and passing | ||
| through the point (1,0), and the ray ending at the origin and passing |
There was a problem hiding this comment.
Use backticks around code keywords (and space after ,)
keras_core/ops/numpy.py
Outdated
| The quadrant (i.e., branch) is chosen so that `arctan2(x1, x2)` is the | ||
| signed angle in radians between the ray ending at the origin and passing | ||
| through the point (1,0), and the ray ending at the origin and passing | ||
| through the point (x2, x1). (Note the role reversal: the “y-coordinate” is |
There was a problem hiding this comment.
Use " as the quote character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more docstrings to functions in ops.numpy.
Covers all remaining functions starting with "a":
I largely copied the docs from numpy, adapting them when the arguments differed.