-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some docstrings ops/nn.py #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Thanks for the review @fchollet. Is there any reason both scale and alpha parameters are omitted in selu activation here? keras-core/keras_core/ops/nn.py Lines 209 to 212 in db9d734
If this is due to a mistake, I can fix it in a separate PR. |
They're not included in the backend ops either. This looks normal. |
@fchollet Thanks for the info. Can you review it once more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
I added some missing docstrings to the activation functions.