Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some docstrings ops/nn.py #677

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Added some docstrings ops/nn.py #677

merged 4 commits into from
Aug 8, 2023

Conversation

Frightera
Copy link
Contributor

I added some missing docstrings to the activation functions.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras_core/ops/nn.py Outdated Show resolved Hide resolved
@Frightera
Copy link
Contributor Author

Frightera commented Aug 8, 2023

Thanks for the review @fchollet.

Is there any reason both scale and alpha parameters are omitted in selu activation here?

def selu(x):
if any_symbolic_tensors((x,)):
return Selu().symbolic_call(x)
return backend.nn.selu(x)

If this is due to a mistake, I can fix it in a separate PR.

@Frightera Frightera requested a review from fchollet August 8, 2023 16:13
@fchollet
Copy link
Contributor

fchollet commented Aug 8, 2023

Is there any reason both scale and alpha parameters are omitted in selu activation here

They're not included in the backend ops either. This looks normal.

@Frightera
Copy link
Contributor Author

@fchollet Thanks for the info. Can you review it once more?

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit 2b70ae5 into keras-team:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants