Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in WhileLoop docstring in core.py #703

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Fix typo in WhileLoop docstring in core.py #703

merged 1 commit into from
Aug 12, 2023

Conversation

Faisal-Alsrheed
Copy link
Contributor

@Faisal-Alsrheed Faisal-Alsrheed commented Aug 12, 2023

Summary
This fixes a small typo in the WhileLoop docstring in core.py

Changes

  • In WhileLoop docstring, fix "implemetation" to "implementation"

Location
https://github.com/keras-team/keras-core/blob/main/keras_core/ops/core.py#L233

Note: I know it's a very simple change :) , but this is my first pull request ever, and I am still learning how to use GitHub. I love this project; it's very future-proof. I am aiming to be a helpful and active contributor.

@google-cla
Copy link

google-cla bot commented Aug 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Faisal-Alsrheed Faisal-Alsrheed changed the title Fix typo in WhileLoop docstring Fix typo in WhileLoop docstring in core.py Aug 12, 2023
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fchollet fchollet merged commit d1b101b into keras-team:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants