Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tf.keras for expected result in Conv1D Test #725

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Replace tf.keras for expected result in Conv1D Test #725

merged 1 commit into from
Aug 14, 2023

Conversation

sampathweb
Copy link
Collaborator

Replaces tf.keras with numpy implementation for conv1d test. Will do the same for Conv2D and Conv3D in a subsequent PR.

fchollet
fchollet approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@fchollet fchollet merged commit 4a579e0 into keras-team:main Aug 14, 2023
@sampathweb sampathweb deleted the replace-tf-keras-conv1d-test branch August 14, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampathweb @fchollet