Convert cyclegan to keras-core #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Aug 15, 2023
| from keras_core import layers | ||
| from keras_core import ops | ||
|
|
||
| import tensorflow # tf.GradientTap for training |
There was a problem hiding this comment.
Use import tensorflow as tf. Since this example is in the tensorflow/ folder there's no need to add comments to justify the TF import.
|
|
||
| import tensorflow # tf.GradientTap for training | ||
| import tensorflow.data as tf_data | ||
| import tensorflow.image as tf_image |
There was a problem hiding this comment.
Likewise you can just use tf.data and tf.image directly
| ## Setup | ||
| """ | ||
|
|
||
| #!pip install -q git+https://github.com/keras-team/keras-core |
| [padding_width, padding_width], | ||
| [0, 0], | ||
| ]) | ||
| return ops.pad(input_tensor, ops.convert_to_tensor(padding_tensor), mode='reflect') |
There was a problem hiding this comment.
Make sure to run black on the file to format the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CycleGan model has a custom tf-based
train_step(), which its not backend-agnostic.