Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert "English-to-Spanish translation with KerasNLP" to keras-core #777

Conversation

freedomtan
Copy link
Contributor

@freedomtan freedomtan commented Aug 23, 2023

  1. colab notebook
  2. diff b8f73d5
  • keras -> keras_croe
  • some tf ops -> keras_core.ops
  • tf.data -> tf_data
  • remove mask_zero = True because it causes an error and is not necessary for this example

@sachinprasadhs sachinprasadhs added the keras-team-review-pending To be discussed by the Keras team label Aug 23, 2023
@freedomtan freedomtan force-pushed the convert_neural_machine_translation_with_keras_nlp branch from 9ae2241 to b8f73d5 Compare August 24, 2023 02:49
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchollet fchollet merged commit 339c15f into keras-team:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keras-team-review-pending To be discussed by the Keras team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants