Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reduce_shape + Add tests to operation_utils_test.py #826

Conversation

Faisal-Alsrheed
Copy link
Contributor

@Faisal-Alsrheed Faisal-Alsrheed commented Aug 31, 2023

  1. Adding several test functions covering various scenarios for functions such as compute_pooling_output_shape, compute_conv_output_shape, compute_reshape_output_shape, and reduce_shape. Tests include different padding types, strides, and input shapes to ensure comprehensive coverage.

  2. Fixing the reduce_shape function to work correctly with different axis and keepdims parameters.

@Faisal-Alsrheed Faisal-Alsrheed changed the title Increase-tests-in-ops/operation_utils_test.py Fix reduce_shape + Add tests to operation_utils_test.py Aug 31, 2023
@Faisal-Alsrheed Faisal-Alsrheed changed the title Fix reduce_shape + Add tests to operation_utils_test.py Fix reduce_shape + Add tests to operation_utils_test.py Aug 31, 2023
@Faisal-Alsrheed Faisal-Alsrheed marked this pull request as ready for review August 31, 2023 13:59
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@fchollet fchollet merged commit 8aa504f into keras-team:main Aug 31, 2023
@Faisal-Alsrheed Faisal-Alsrheed deleted the Increase-tests-in-ops/operation_utils_test.py branch September 7, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants