Update minimum python version to 3.9 to align with TF/JAX #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 75.99% 75.99%
=======================================
Files 328 328
Lines 31099 31099
Branches 6051 6051
=======================================
Hits 23635 23635
Misses 5866 5866
Partials 1598 1598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The PR title currently says 3.8, but I think it should be 3.9, right? I think updating to 3.9 for KerasCV should be fine. |
sampathweb
changed the title
Thanks. Updated the PR title to 3.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tests are running with
JAX==0.4.13which was the last version that supported Python 3.8. The latestjaxversion is0.4.14. TensorFlow also has dropped python 3.8 in the upcoming2.14release. Numpy has already dropped it. So updatingkeras-coreto use Python 3.9 as the minimum version.